Fix: Clamp currentIndex within valid bounds and update related state logic #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update all related state and logic to use the clamped value.
Collaborator
|
@thanhcuong1990 Hey! Would you mind uploading videos with Before and After? I mean a video showing the issue and other showing how this fix it. Thanks for the pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where currentIndex could go out of bounds, leading to incorrect state updates or unexpected UI behavior.
It addresses issue #14.
Changes
• Clamped currentIndex to ensure it always stays within valid bounds.
• Updated all related state and logic to use the clamped value.
• Minor refactor to improve code clarity and prevent similar issues.
Impact
• Prevents crashes or visual glitches when navigating beyond the valid index range.
• Ensures consistent behavior across all components relying on currentIndex.
Testing
• Verified correct behavior at boundary indices (first and last).
• Confirmed no regressions during normal carousel navigation.