Skip to content

Conversation

ben
Copy link

@ben ben commented Aug 14, 2014

raw.github.com has been deprecated. This updates the installation instructions to use curl, as well as the raw.githubusercontent.com domain.

@fingolfin
Copy link
Contributor

Switching to curl by default is helpful on OS X, which ships with curl but not wget; so with this change, installation will work "out of the box" there.

The only thing I slightly dislike about this is the commit message. It does not make clear that the README is modified, not git-remote-hg itself. Perhaps this would do:

"README: fix raw github URLs and replace wget by curl

raw.github.com has been deprecated, use raw.githubusercontent.com instead.
Also, use curl instead of wget.
"

@fingolfin
Copy link
Contributor

@ben I cherry picked this into my git-remote-hg fork, with the adjusted commit message; if you are unhappy with that, I will of course change it back and/or change it to something you prefer. See https://github.com/fingolfin/git-remote-hg

@ben
Copy link
Author

ben commented Jan 13, 2015

Looks great to me. I'll close this out. Thanks!

@ben ben closed this Jan 13, 2015
@ben ben deleted the patch-1 branch January 13, 2015 18:49
@felipec
Copy link
Owner

felipec commented May 17, 2016

Deprecated? Seems to work fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants