Few fixes and updates against cleware#1
Open
andy-shev wants to merge 4 commits intofelipebalbi:masterfrom
Open
Few fixes and updates against cleware#1andy-shev wants to merge 4 commits intofelipebalbi:masterfrom
andy-shev wants to merge 4 commits intofelipebalbi:masterfrom
Conversation
andy-shev
commented
Feb 1, 2021
andy-shev
commented
- Fix exit when libusb backend is in use
- Fix inconsistency with port numbering when reading and printing
- Don't allow to enter port numbers less than 1
- Allow to choose the HID API backend
./configure --with-hidapi=hidapi-libusb Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
With libusb backend the exit of the main() fails with cleware: ../../libusb/os/threads_posix.h:58: usbi_mutex_destroy: Assertion `pthread_mutex_destroy(mutex) == 0' failed. This is due to resource leakage which is fixed by closing HID device properly. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Author
|
Felipe, can this be merged, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.