fix(bloc_lint): reset the @override flag between class members

[mysCod3r]

Status

READY

Breaking Changes

NO

Description

• fix(bloc_lint): reset the @override flag between class members (closes fix: _isOverride is never reset, so lint rules skip every member after an @override #4863)

avoid_public_bloc_methods and prefer_void_public_cubit_methods each keep an _isOverride flag that was only ever written from beginMetadata, which fires only for declarations that have an annotation. The flag was therefore never cleared, so an @override on one member exempted every member after it, and a member annotated with @override plus anything else was reported despite the exemption.

beginMetadataStar fires for every member before its metadata is read, so it is the point at which the flag can be cleared. beginMember is not usable for this, since it runs after the metadata and clearing there would drop a legitimate @override.

Both rules now clear the flag on beginMetadataStar and accumulate in beginMetadata instead of assigning, which fixes the false negative and the false positive respectively.

Three regression tests are included, one per defect plus the avoid_public_bloc_methods case. Each fails without the change and passes with it. The suite goes from 151 to 154 tests, and bloc_lint stays at 100% coverage.

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore