Skip to content

fix(vscode): show context menu conditionally #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 7, 2023
Merged

fix(vscode): show context menu conditionally #3989

merged 14 commits into from
Nov 7, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Nov 2, 2023 •
edited
Loading

Status

READY

Note: Since the extension has no tests, I recommend verifying the behaviour manually locally.

Breaking Changes

NO

Description

Resolves #3948

Demonstration

Screen.Recording.2023-11-02.at.23.36.48.mov

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago requested a review from felangel as a code owner November 2, 2023 23:38
@alestiago alestiago changed the title fix: stop showing bloc context menu contributions when there is no open bloc project fix: stop showing bloc context menu contributions when there is no bloc project opened Nov 2, 2023
@tenhobi
Copy link
Collaborator

tenhobi commented Nov 3, 2023

The code looks good! It's simpler than I expected haha.

Any tips on how I can test that locally?

@alestiago
Copy link
Contributor Author

alestiago commented Nov 3, 2023 •
edited
Loading

@tenhobi thanks for the comment. I'm glad it looks simple, that's part of the aim!

The steps for testing it locally are the following:

  1. Clone the repository and open extensions/vscode directory.

  2. Install all dependencies.

npm i
  1. Compile the project:
npm run compile

Compilation should succeed, if it does't let me know.

  1. Run the project on a Development Host Window by pressing F5 and selecting it as a target.

  2. From the Development Host Window open a sample project in your directory to play around with.

Note: I think it will be good idea to include CONTRIBUTING information with all these steps, you may want to take inspiration from Dart Frog's VS Code CONTRIBUTING.

felangel
felangel reviewed Nov 7, 2023
View reviewed changes
felangel
felangel reviewed Nov 7, 2023
View reviewed changes
@felangel felangel changed the title fix: stop showing bloc context menu contributions when there is no bloc project opened fix(vscode): show context menu conditionally Nov 7, 2023
felangel
felangel approved these changes Nov 7, 2023
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for taking the time to do this! 💙

@felangel felangel added bug Something isn't working extension This issue relates to bloc extensions labels Nov 7, 2023
@felangel felangel merged commit c6893c1 into felangel:master Nov 7, 2023
@tom-sanderson-bt tom-sanderson-bt mentioned this pull request May 13, 2024
Closed
@khoadng khoadng mentioned this pull request Jun 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@alestiago alestiago

Labels
bug Something isn't working extension This issue relates to bloc extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(vscode): do not show context menu contributions when not in a Bloc project
3 participants
@alestiago @tenhobi @felangel