Skip to content

Run installation script with pipenv on PATH #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Run installation script with pipenv on PATH #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/PythonBridge-Pharo/PBPharoPlatform.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,17 @@ PBPharoPlatform >> forceInstallEnvironmentForApp: application [
self assert: PBPharoPipenvProcess pipenvPath isEmptyOrNil not description: 'pipenv is apparently not accessible at a standard location. Please, have a look at the Troubleshooting section of https://objectprofile.github.io/PythonBridge/pages/pharo-installation'.
proc := OSSUnixSubprocess new
command: '/bin/bash';
addAllEnvVariablesFromParentWithoutOverride;
arguments: (Array
with: ((self runtimeFolderForApplication: application) / 'install_env.sh') fullName);
terminateOnShutdown;
runAndWait.
addAllEnvVariablesFromParentWithoutOverride.
proc
environmentAt: 'PATH'
put: (PBPharoPipenvProcess pipenvPath
asFileReference parent fullName),
':', (proc envVariables at: 'PATH').
proc
arguments: (Array
with: ((self runtimeFolderForApplication: application) / 'install_env.sh') fullName);
terminateOnShutdown;
runAndWait.
proc isSuccess ifFalse: [ self signalPipenvCreateEnvFailed ].
]

Expand Down