Apply more stringent linter rules

.eslintrc.json

@@ -1,16 +1,30 @@
 {
   "rules": {
     "no-with": 2,
+    "template-curly-spacing": ["error", "always"],
     "max-len": [
       2,
       250
     ],
+    "no-undef": "off",
+    "no-extra-semi": ["error"],
+    "no-empty":["error"],
+    "multiline-comment-style": ["error", "starred-block"],
+    "linebreak-style": ["error", "unix"],
+    "no-unused-vars": ["error"],
+    "no-trailing-spaces": ["error"],
+    "no-console": ["warn",{
+      "allow": ["warn","error"]
+    }],
     "indent": [
       2,
       4,
       {
         "SwitchCase": 1
       }
     ]
-  }
+  },
+  "env": {
+    "es6": true
+}
 }

lib/BotFramework.js

@@ -6,8 +6,10 @@ function BotFrameworkBot(configuration) {
     // Create a core botkit bot
     var bf_botkit = Botkit(configuration || {});
 
-    // customize the bot definition, which will be used when new connections
-    // spawn!
+    /*
+     * customize the bot definition, which will be used when new connections
+     * spawn!
+     */
     bf_botkit.defineBot(function(botkit, config) {
 
         var bot = {
@@ -17,7 +19,7 @@ function BotFrameworkBot(configuration) {
         };
 
         bot.send = function(message, cb) {
-            function done(err, res) {
+            function done(err) {
                 if (cb) {
                     cb(err);
                 }
@@ -112,10 +114,12 @@ function BotFrameworkBot(configuration) {
 
     bf_botkit.middleware.normalize.use(function(bot, message, next) {
 
-        // Break out user & channel fields from event
-        // - These fields are used as keys for tracking conversations and storage.
-        // - Prefixing with channelId to ensure that users & channels for different
-        //   platforms are unique.
+        /*
+         * Break out user & channel fields from event
+         * - These fields are used as keys for tracking conversations and storage.
+         * - Prefixing with channelId to ensure that users & channels for different
+         *   platforms are unique.
+         */
 
         var prefix = message.address.channelId + ':';
         message.user = prefix + message.address.user.id;
@@ -174,6 +178,6 @@ function BotFrameworkBot(configuration) {
     };
 
     return bf_botkit;
-};
+}
 
 module.exports = BotFrameworkBot;

lib/ConsoleBot.js

@@ -41,6 +41,7 @@ function TextBot(configuration) {
         };
 
         bot.send = function(message, cb) {
+            // eslint-disable-next-line no-console
             console.log('BOT:', message.text);
             if (cb) {
                 cb();
@@ -101,6 +102,6 @@ function TextBot(configuration) {
     };
 
     return text_botkit;
-};
+}
 
 module.exports = TextBot;