Skip to content

Make torch optional #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2020
Merged

Make torch optional #85

merged 3 commits into from
May 28, 2020

Conversation

LouisTrezzini
Copy link
Contributor

No description provided.

kireet
kireet approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@kireet kireet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we also need to update the readme to mention that torch is an optional dependency and how to install it? how do you install optionals via pip?

setup.py
@@ -17,12 +17,15 @@
keywords=['NLP', 'transfer learning', 'language models', 'NLU'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also bump the version above on line 8? not sure why i can't comment on that line.

@LouisTrezzini LouisTrezzini merged commit 85515b7 into master May 28, 2020
@LouisTrezzini LouisTrezzini deleted the optional-torch branch May 28, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kireet kireet kireet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LouisTrezzini @kireet