Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Nov 30, 2018

Jira link(s)

https://issues.jboss.org/browse/RHMAP-22002

What

Add default result for init requests across domains when the result is not successful which is expected when the connection tag is disable.

Why

In this situation all values are returned as undefined which has been a complain by its users.

How

If all be undefined then return a descriptive and default message.

Verification Steps

  1. Create a WebApp project
  2. Clone locally this PR and run ( npm install and grunt )
  3. Update the main.js file in the client web app in the platform with the "dist/feedhenry.js" generated locally.
  4. Disable the connection tab
  5. Copy the index.html and hello.js to the public dir of the web client app
  6. Update the index.html to looking for hello.js in the public dir
  7. Deploy it
  8. Test it by the preview. The following result is the expected one when the button is clicked.

screenshot 2018-11-30 at 11 19 24

NOTE: It can be tested here: https://support.eu.feedhenry.com/?#projects/qi6v7wo4psfilh6y7furo6hm/apps/qi6v7wnhylp2y7u4m3r4i67v/deploy

The dev tag created to test it is: 3.0.12-dev-1

Checklist:

  • Code has been tested locally by PR requester (Full tested with WebApp as described in the steps, and with Cordova and with Ionic template + webviews. See here)

img_e5a6cc0070fc-1

  • Changes have been successfully verified by another team member

Copy link

@shannon shannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Camilia and I discussed that this solution is not perfect because the actual error can not be returned from the JSONP failure but this should allow users to at least detect a JSONP error and the change shouldn't affect any errors outside of JSONP failures.

@camilamacedo86 camilamacedo86 merged commit 4a90b8a into master Nov 30, 2018
@camilamacedo86 camilamacedo86 deleted the IMP_COR_MSG branch November 30, 2018 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants