Skip to content

FDG-8045 Improve Code Coverage - chart-primary#2067

Merged
jdach merged 9 commits intomasterfrom
FDG-8045
Feb 5, 2026
Merged

FDG-8045 Improve Code Coverage - chart-primary#2067
jdach merged 9 commits intomasterfrom
FDG-8045

Conversation

@ntsim99
Copy link
Contributor

@ntsim99 ntsim99 commented Feb 4, 2026

JIRA Ticket:

FDG-18045

The following are ALL required for the PR to be merged:

  • Provided testing instructions in JIRA ticket if applicable
  • Provided mocks or additional information in JIRA ticket if applicable
  • Verified cross-browser compatibility: Chrome, Safari, Firefox, Edge
  • Verified mobile/tablet/desktop/monitor responsiveness
  • Verified that this PR does not create any new accessibility issues (via Axe Chrome)
  • Verify all files are covered by at least 90% test coverage if applicable
  • Check for code quality
    + Watch out for irrelevant changes
    + Take time to understand the logic and flow; be on guard for pitfalls
    + Look at handoff between components (esp. number of props)
    + Watch out for literals (vs. variables) for css specs if applicable

@ntsim99
Copy link
Contributor Author

ntsim99 commented Feb 4, 2026

The index.js file has been increased from 55% to 94% coverage - I am still working on the other two files.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Total Line Coverage: 92.57% ✅

@ntsim99 ntsim99 marked this pull request as ready for review February 4, 2026 18:24
@jdach jdach self-requested a review February 5, 2026 14:32
@jdach jdach self-assigned this Feb 5, 2026
Copy link
Contributor

@jdach jdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look great

@jdach jdach merged commit adefdb2 into master Feb 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants