compatibility for bootc image #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say-paul
force-pushed
the
boot_compatibility
branch
from
a5670bd
to
3197726
Compare
miabbott
reviewed
Aug 8, 2024
LorbusChris
reviewed
Aug 8, 2024
say-paul
force-pushed
the
boot_compatibility
branch
3 times, most recently
from
a771ffe
to
8f2ccff
Compare
say-paul
force-pushed
the
boot_compatibility
branch
from
8f2ccff
to
1c1a927
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
say-paul
force-pushed
the
boot_compatibility
branch
from
24884c1
to
ad7feac
Compare
say-paul
changed the title
say-paul
force-pushed
the
boot_compatibility
branch
from
ad7feac
to
b7ebeb2
Compare
runcom
reviewed
Aug 14, 2024
usr/libexec/greenboot/greenboot-rpm-ostree-grub2-check-fallback
Outdated
Show resolved
Hide resolved
say-paul
force-pushed
the
boot_compatibility
branch
from
83ecd7d
to
cf9470b
Compare
Support is added for greenboot to work with read-only /boot. It uses PrivateMounts=yes to isolate the system and remounts boot as rw followed by setting the grub parameters as per healthcheck. The following services are affected: greenboot-grub2-set-success.service greenboot-grub2-set-counter.service greenboot-rpm-ostree-check-fallback.service The grub2-editenv command is decoupled from greenboot-grub2-set-success.service and is part of a separate script. Signed-off-by: saypaul <paul.sayan@gmail.com>
greenboot will able able to detect the image type of the os, i.e ostree or bootc and use the correct verb to rollback to previous stable deployment. Signed-off-by: saypaul <paul.sayan@gmail.com>
say-paul
force-pushed
the
boot_compatibility
branch
from
cf9470b
to
6b51ec9
Compare
runcom
approved these changes
Aug 16, 2024
|
Thanks, I was just recently seeing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables greenboot to work with bootc image alongside supporting ostree based image.
Its achieved by:
The following services are affected:
The grub2-editenv command is decoupled from greenboot-grub2-set-success.service and is part of a separate script.
fixes: #136 .
fixes: #135