Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static grub config #129

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

cgwalters
Copy link
Contributor

This pairs with coreos/bootupd#543 to have bootupd support injecting the greenboot grub logic only if greenboot is installed.

This pairs with coreos/bootupd#543
to have bootupd support injecting the greenboot grub logic
only if greenboot is installed.
@nullr0ute
Copy link
Member

How does this impact users that may not have moved to bootupd/unified core yet?

@LorbusChris
Copy link
Member

LorbusChris commented Oct 25, 2023

To add some more context: This config snippet originates with grub2-tools, but it's excluded in FCOS.
I'm not familiar with the reasons of osbuild carrying another copy of that snippet.

Desktop variants currently use:

How would these snippets be shipped for e.g. the Silverblue ostree native container image? Do all the snippets have to shipped in /usr/lib/bootupd/grub2-static/configs.d/ going forward in order to work with bootupd? How are they ordered?

Should 08_fallback_counting be removed from grub2-tools after this merges to make this repo here the canonical location?

@cgwalters
Copy link
Contributor Author

How does this impact users that may not have moved to bootupd/unified core yet?

If bootupd isn't used (as it's not today for IoT/Edge) there is zero impact other than a small new file in /usr that is unused.

To add some more context: This config snippet originates with grub2-tools, but it's excluded in FCOS. I'm not familiar with the reasons of osbuild carrying another copy of that snippet.

So one thing going on here is many of us really want a "static grub config" where we don't run grub2-mkconfig and especially not os-prober for every kernel update.

@cgwalters
Copy link
Contributor Author

@runcom
Copy link
Member

runcom commented Feb 12, 2024

Given low impact as per #129 (comment) and since we're moving to bootupd, this ease with testing that flow too.

lgtm

@runcom runcom merged commit 332e5e3 into fedora-iot:main Feb 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants