Check the new code in a side-directory #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a better Ruff linter isolation; without this, Ruff traverses all the gitroot sub-directories, including separate worktrees, temporary files, etc. Then, since potential issues in such files are not present in the "old code" (even before linted on a clean checkout), vcs-diff-lint would report such irrelevant errors as "new" issues. After this commit, both the old and new code is analyzed in a clean separate temporary directory. Complements: 38412fb
|
I didn't test it but LGTM |
FrostyX
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a better Ruff linter isolation; without this, Ruff traverses all the gitroot sub-directories, including separate worktrees, temporary files, etc. Then, since potential issues in such files are not present in the "old code" (even before linted on a clean checkout), vcs-diff-lint would report such irrelevant errors as "new" issues.
After this commit, both the old and new code is analyzed in a clean separate temporary directory.
Complements: 38412fb