Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review page feature #140

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Review page feature #140

merged 4 commits into from
Aug 6, 2024

Conversation

nikromen
Copy link
Member

@nikromen nikromen commented Jul 16, 2024

This should be more or less the final look of the review page.

Fixes: #4

@nikromen nikromen force-pushed the review-pr branch 2 times, most recently from 6e32add to 378d157 Compare July 16, 2024 16:20
if os.environ.get("ENV") == "production":
raise NotImplementedError("Reviewing is not ready yet")

def frontend_review_random():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no type?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The response structure is checked at the return statement with feedback schema - there's just added id for the reference and I didn't want to add another unicorn schema to schema.py since this will disappear with database creation and simply the structure is parsed - just the id is added at the end.

backend/src/api.py Outdated Show resolved Hide resolved
@FrostyX
Copy link
Member

FrostyX commented Jul 19, 2024

@nikromen I see you rebased. Were there any manual merge conflicts or everything went fine?

@nikromen
Copy link
Member Author

@FrostyX there were 2 big merge conflicts with needs of manual resolving - since a lot o fit was on frontend I created another branch for this PR if I screwed since I don't know much about the FE part. But it seems like it's working fine

@nikromen nikromen force-pushed the review-pr branch 3 times, most recently from 0649636 to 36c16bd Compare July 22, 2024 09:27
@TomasTomecek
Copy link
Collaborator

I checked it out locally (36c16bd)

and sadly when I click on 'review logs' I get 405:

frontend_1  | shadow-cljs - dependencies updated
frontend_1  | shadow-cljs - HTTP server available at http://localhost:3000
frontend_1  | shadow-cljs - server version: 2.26.7 running at http://localhost:9630
frontend_1  | shadow-cljs - nREPL server started on port 3333
frontend_1  | shadow-cljs - watching build :app
frontend_1  | [:app] Configuring build.
frontend_1  | [:app] Compiling ...
frontend_1  | [:app] Build failure:
frontend_1  | ------ ERROR -------------------------------------------------------------------
frontend_1  |  File: /opt/log-detective-website/frontend/src/app/homepage.cljs:249:20
frontend_1  | --------------------------------------------------------------------------------
frontend_1  |  246 |   [:div {:class "card text-center"}
frontend_1  |  247 |    (render-stats)
frontend_1  |  248 |    (render-navigation)
frontend_1  |  249 |    (render-cards)])
frontend_1  | --------------------------^-----------------------------------------------------
frontend_1  | app/homepage.cljs [line 249, col 20] Unmatched delimiter ).
frontend_1  |
frontend_1  | --------------------------------------------------------------------------------
frontend_1  |  250 |
frontend_1  | --------------------------------------------------------------------------------
frontend_1  |
backend_1   | INFO:     10.89.0.2:58726 - "GET / HTTP/1.1" 200 OK
backend_1   | INFO:     10.89.0.2:58726 - "GET /css/style.css HTTP/1.1" 200 OK
backend_1   | INFO:     10.89.0.2:58728 - "GET /img/fedora.svg HTTP/1.1" 200 OK
backend_1   | INFO:     10.89.0.2:58732 - "GET /static/js/main.js HTTP/1.1" 200 OK
backend_1   | INFO:     10.89.0.2:58732 - "GET /stats HTTP/1.1" 200 OK
backend_1   | INFO:     10.89.0.2:58732 - "GET /img/copr-logo.png HTTP/1.1" 200 OK
backend_1   | INFO:     10.89.0.2:58732 - "GET /img/favicon.ico HTTP/1.1" 200 OK
backend_1   | INFO:     10.89.0.2:58744 - "GET /review/ HTTP/1.1" 307 Temporary Redirect
backend_1   | INFO:     10.89.0.2:58744 - "GET /review HTTP/1.1" 200 OK
backend_1   | INFO:     10.89.0.2:58744 - "GET /frontend/review HTTP/1.1" 405 Method Not Allowed

@nikromen nikromen force-pushed the review-pr branch 2 times, most recently from 81e31dc to 7775f87 Compare July 22, 2024 14:49
@TomasTomecek
Copy link
Collaborator

We've worked with @nikromen on how to run this locally. Turned out I hate to wipe evrything in frontend/, rebuild images from scratch (--no-cache) and bindmind persisntent volume with :Z.

@TomasTomecek
Copy link
Collaborator

Once I submit a review, it's great that I get a message saying

Thank you!
Successfully submitted, thank you for your contribution.

And a link to submit "Another log" which redirects me to /. I know I'm picking nits - would it be better to say "Thank you for your review!", with button "Submit another review" that would immediately take you to another random log.

Comment on lines +320 to +321
# TODO: temporary silly solution until database is created
# (missing provider but we can dig it from original feedback file)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused about that directory structure, now I understand :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it won't turn into this :D
image

backend/src/api.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments. Works well for me now!

@FrostyX FrostyX merged commit 1fdd888 into main Aug 6, 2024
7 checks passed
@jpodivin jpodivin deleted the review-pr branch August 7, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page for reviewing collected data
4 participants