add Frostyx's youtube video to documentation page #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrostyX
reviewed
Jun 28, 2024
| <div class="card"> | ||
| <div class="card-body"> | ||
| <h5 class="card-title">Demo with comments</h5> | ||
| <a target="_blank" rel="noopener noreferrer" href="https://www.youtube.com/watch?v=_-O7ryKCnlQ"><img src="/img/youtube-preview.jpg" alt="Demo video" style="max-width: 100%; display: inline-block;" /></a> |
There was a problem hiding this comment.
Did you intentionally not use the embed iframe or you don't know them?
If you go to a youtube video https://www.youtube.com/watch?v=_-O7ryKCnlQ and then click the "Share" button (next to likes and dislikes) and then click "Embed", it generates an <iframe> for you. Which is the way youtube videos are typically displayed on websites. See e.g. here https://frostyx.cz/posts/lsp-for-vim-boomers
It's easy to adjust the widht and height properties as needed.
I'd probably do it that way but if you intentionally wanted to do it with an image and link to youtube, I am okay with that as well.
There was a problem hiding this comment.
I intentionally did not use it.
FrostyX
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.