Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add demo video to the first page of website #136

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

xsuchy
Copy link
Member

@xsuchy xsuchy commented Jun 28, 2024

No description provided.

@FrostyX
Copy link
Member

FrostyX commented Jun 28, 2024

For some reason, the gif doesn't appear when I try to run this.

Screenshot_2024-06-28_15-13-03

@FrostyX
Copy link
Member

FrostyX commented Jun 28, 2024

Also, what do you think about mentioning the youtube video in some sentence below the gif?

@xsuchy
Copy link
Member Author

xsuchy commented Jun 28, 2024

Also, what do you think about mentioning the youtube video in some sentence below the gif?

I want to mention on Documentation page (and do it in separate PR).

And I think that it may confuse people when a-href will point to different video than what they see.

@xsuchy
Copy link
Member Author

xsuchy commented Jun 28, 2024

For some reason, the gif doesn't appear when I try to run this.

Strange. It worked for me when I tried npx shadow-cljs watch app. Any idea what can be wrong?

@xsuchy
Copy link
Member Author

xsuchy commented Jun 28, 2024

I changed relative link to absolute. Can you try now?

@FrostyX
Copy link
Member

FrostyX commented Jun 28, 2024

Maybe this is my error? I cannot even open the gif image

Screenshot_2024-06-28_16-24-43

However, the same error happens when I try to open the file in main.
I'll try to debug later.

@xsuchy
Copy link
Member Author

xsuchy commented Jun 28, 2024

Note that in this PR I moved the file to different directory.

@Fan
Copy link
Collaborator

Fan commented Jul 19, 2024

Just tested it and the gif seems to be working correctly and displays correctly when I run it locally
image

@FrostyX
Copy link
Member

FrostyX commented Jul 19, 2024

Probably an error on my side then? Let's merge and see if it works in production.

@FrostyX FrostyX merged commit ddc3616 into fedora-copr:main Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants