Adding some tests #8
Conversation
| "modified": ["MODIFIED.md"] | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
I would avoid simplified payloads like this because if we make a mistake here, then we can accidentally write our code in a way that it passes the test but doesn't work in reality. I'd much rather commit the whole payload files that we use for development. Please only make sure there is no sensitive information like email addresses.
I use real data for testing one of my other projects, and it's really reliable
https://github.com/FrostyX/fedora-review-service/tree/main/tests/data
With the added benefit that once you encounter something that doesn't work for some reason, you can add the whole payload, and fix the code.
| result = subprocess.run( | ||
| [sys.executable, str(SCRIPT_PATH)] + args, capture_output=True, text=True | ||
| ) | ||
| return result |
There was a problem hiding this comment.
IMHO we should write the tests in a way that doesn't require running the script. But we will have to make some adjustments in the script first.
This PR adds some initial tests.