Migrate to vitest to improve coverage reporting #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
commented
May 25, 2025
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "noPropertyAccessFromIndexSignature": true | ||
| "noPropertyAccessFromIndexSignature": false |
Contributor
Author
There was a problem hiding this comment.
@dahlia I disabled this because it conflicts with biome's rules.
ThisIsMissEm
force-pushed
the
fix/code-coverage-errors
branch
from
20f345b to
48d189b
Compare
This was referenced May 25, 2025
Open
dahlia
approved these changes
May 25, 2025
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Really thanks for your huge work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c8 was giving misleading coverage reports for files containing jsx, which made assessing where we were at with test coverage difficult.
I also tried using nyc, one-double-zero and borp, but all these didn't work or give good results either.
This does mean we're no longer using
node:test, and I have encountered some issues in watch mode with database deadlocks that don't normally occur in full runs, so I think vitest may not always be running sequentially.