-
Notifications
You must be signed in to change notification settings - Fork 1
feat(actor): Add key retrieval functionality to Actor class #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduces keys property to Actor class, providing a unified list of public_key and assertion_method. Adds get_key method to Actor for retrieving keys by their ID.
for more information, see https://pre-commit.ci
Summary of ChangesHello @AmaseCocoa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces valuable key retrieval functionality to the Actor class, including new properties and methods, along with corresponding tests. The implementation is straightforward. I have identified a few areas for improvement to enhance code quality and correctness. My main feedback points are a critical issue in src/apmodel/__init__.py where __all__ is incorrectly defined, a suggestion to use a more idiomatic Python pattern in src/apmodel/vocab/actor.py, and a style guide violation in tests/test_actor.py regarding import placement. Addressing these points will improve the overall quality of the code.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…into feat/key-in-one
for more information, see https://pre-commit.ci
…into feat/key-in-one
for more information, see https://pre-commit.ci
Introduces keys property to Actor class, providing a unified list of
public_key and assertion_method. Adds get_key method to Actor for
retrieving keys by their ID.