Fix build script for musl builds that require SASL #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly want to see an update to to the reconnection issue on 2.10. Changes the test kafka to bitnamilegacy/kafka as all images were moved here. Seems to be a risk that these images will also be removed at some point so finding another source for running kafka for testing would be good. Closes fede1024#789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #803. It fixes the library path for sasl2 and libz since both crates produce the artifacts in
/lib. Additionally, it adds the libsasl2.pc to thepkg-configpath because librdkafka only uses pkg-config to locate the sasl2 library. With these changes it is possible to build rdkafka for a musl target.