Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport-commons): Fix HTTP status precedence #3511

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Jul 9, 2024

Closes #1745

@daffl daffl requested a review from marshallswain July 9, 2024 22:26
Copy link
Member

@marshallswain marshallswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

Deploying feathers-dove with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6d55989
Status: ✅  Deploy successful!
Preview URL: https://5ddf311e.feathers.pages.dev
Branch Preview URL: https://http-status-codes.feathers.pages.dev

View logs

@daffl daffl merged commit 5d999a0 into dove Jul 10, 2024
5 checks passed
@daffl daffl deleted the http-status-codes branch July 10, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning undefined from service's method, always get 404 HTTP Status instead of 204
2 participants