-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: vitest #3344
base: v6
Are you sure you want to change the base?
chore: vitest #3344
Conversation
- chore: migrate from callbacks to Promises - chore: do not use static ports, use pkg 'get-port' instead
- test: rename (done) to (resolve, reject)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you also change the building & dev tools to vite ?
For reference, I am using vite & vitest now with feathers .
So if you need any help . I am here
I'd be open to this if the tests all pass, it run faster and supports a watch mode where it runs a package test suite on code changes. Personally I was debating of moving everything to the new built-in Node test runner to reduce dependencies and - now that it is stable - also have to worry less about version upgrades (which was finicky sometimes even with Mocha which hasn't really changed much). But it's still clunky to use in some cases. For example, it doesn't support running TypeScript tests recursively (except with a programmatic hack). |
I started using Vitest in another project and it is indeed working quite nicely and was the only test runner that worked with ES modules out of the box so this might also help us with the pains from #3375 |
Deploying feathers-dove with Cloudflare Pages
|
CI is broken for some reason. Only package that fails is '@feathersjs/knex' I think. But I don't know why. Please @daffl have a look. |
migrate tests to vitest
before
/after
mocha-hooks tobeforeAll
&afterAll