Remove JSON loading from the client version #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
It's a bummer to add a manual step but it is required and slims the build so 👍 |
marshallswain
pushed a commit
to marshallswain/feathers
that referenced
this pull request
Sep 20, 2016
daffl
added a commit
that referenced
this pull request
Aug 25, 2018
* Improve logging hook and add Express error logging * Remove custom errorLogger and use new error middleware logging functionality * Improve the logger more * Make standard logging hook more compact * Finalize logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some loaders (like Webpack) can not require JSON by default so it is best to take out requiring the package to get the version. This will also make built versions a little smaller. The drawback is that we will have to update those versions manually (maybe remove them entirely in 3.0).