Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Generate full client test suite and improve typed client #2788

Merged
merged 7 commits into from
Oct 12, 2022

Conversation

daffl
Copy link
Member

@daffl daffl commented Oct 8, 2022

This pull request adds a test suite for the typed client to the generated application and moves the authentication tests into the client test suite. This helps to ensure that the typed client is fully functional and makes it easy to create full integration tests for an app. It also improves the typed client to dynamically import the actual service signature instead of using a generic interface.

Should close #2775

It also ensures that a standard app can be restarted. Previously, routes got removed on teardown instead of unuse which cause services to be no longer discoverable when the app is restarted (via .teardown() and then calling .setup()) again. The authentication service was also initialising its hooks twice in that case.

@daffl daffl changed the title feat(cli): Generate full client test suite and make app restartable feat(cli): Generate full client test suite and improve typed client Oct 8, 2022
@daffl daffl merged commit 57119b6 into dove Oct 12, 2022
@daffl daffl deleted the cli-client-tests branch October 12, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript error rest client custom method
1 participant