feat(transport-commons): add context.http.response
#2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonagam
force-pushed
the
feat-response-headers
branch
from
29f5c7f to
067152e
Compare
daffl
changed the title
context.http.responseHeaderscontext.http.response
daffl
force-pushed
the
feat-response-headers
branch
from
067152e to
e95e11b
Compare
|
I think this one will work great. Since this allows for redirects, can we close #2484? |
|
Seems so. Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to specify any response headers for http transports.
Related to #2484.
Not sure about naming though. About
responsepart.If
httpis only about outputs (and any inputs go intoparams) then there is no need to specify that this is response headers.If
httpcan contain something besides outputs, then status part should be maybe renamed toresponseStatusfor consistency.I think the first option is more attractive to me with short names - so
status,headersand possiblylocationandcookies(those are headers too, but can be beneficial to add easier way to set them).