fix(schema): Check for undefined value in resolveQueryObjectId resolv…

…er (#2914)
feathersjs · Dec 11, 2022 · d9449fa · d9449fa
1 parent d606ac6
commit d9449fa
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/packages/mongodb/src/resolvers.ts b/packages/mongodb/src/resolvers.ts
@@ -19,6 +19,10 @@ export async function resolveQueryObjectId(
 ): Promise<IdQueryObject<ObjectId>>
 export async function resolveQueryObjectId(value: ObjectIdParam): Promise<ObjectId>
 export async function resolveQueryObjectId(value: ObjectIdParam | IdQueryObject<ObjectIdParam>) {
+  if (!value) {
+    return undefined
+  }
+
   if (typeof value === 'string' || typeof value === 'number' || value instanceof ObjectId) {
     return toObjectId(value)
   }

diff --git a/packages/mongodb/test/resolvers.test.ts b/packages/mongodb/test/resolvers.test.ts
@@ -24,4 +24,12 @@ describe('ObjectId resolvers', () => {
     assert.ok(oids.$in && oids.$in[0] instanceof ObjectId)
     assert.ok(oids.$ne instanceof ObjectId)
   })
+
+  it('resolveQueryObjectId with falsey value', async () => {
+    await resolveQueryObjectId(undefined)
+    await resolveQueryObjectId(null)
+    await resolveQueryObjectId(0)
+
+    assert.ok('Falsey value does not throw exception')
+  })
 })