fix(transport-commons): Allow to properly chain SocketIo client.off (#…

…1706)
feathersjs · Nov 27, 2019 · a4aecbc · a4aecbc
1 parent 2331c2a
commit a4aecbc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/transport-commons/src/client.ts b/packages/transport-commons/src/client.ts
@@ -130,7 +130,9 @@ export class Service {
   // of the emitter-component Socket.io is using
   off (name: string, ...args: any[]) {
     if (typeof this.connection.off === 'function') {
-      return this.connection.off(`${this.path} ${name}`, ...args);
+      const result = this.connection.off(`${this.path} ${name}`, ...args);
+
+      return result === this.connection ? this : result;
     } else if (args.length === 0) {
       // @ts-ignore
       return this.removeAllListeners(name);

diff --git a/packages/transport-commons/test/client.test.ts b/packages/transport-commons/test/client.test.ts
@@ -204,14 +204,15 @@ describe('client', () => {
     connection.emit('todos test', testing);
   });
 
-  it('forwards namespaced call to .off', done => {
+  it('forwards namespaced call to .off, returns service instance', () => {
     // Use it's own connection and service so off method gets detected
     const conn = new EventEmitter();
 
     // @ts-ignore
-    conn.off = name => {
+    conn.off = function (name) {
       assert.strictEqual(name, 'todos test');
-      done();
+
+      return this;
     };
 
     const client = new Service({
@@ -221,6 +222,6 @@ describe('client', () => {
       connection: conn
     });
 
-    client.off('test');
+    assert.strictEqual(client.off('test'), client);
   });
 });