fix(authentication-oauth): Properly handle all oAuth errors (#3284)

feathersjs · Sep 27, 2023 · 148a9a3 · 148a9a3
1 parent ef9ee9d
commit 148a9a3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/authentication-oauth/src/service.ts b/packages/authentication-oauth/src/service.ts
@@ -28,7 +28,7 @@ export class OAuthError extends FeathersError {
   constructor(
     message: string,
     data: any,
-    public location: string
+    public location?: string
   ) {
     super(message, 'NotAuthenticated', 401, 'not-authenticated', data)
   }
@@ -114,12 +114,17 @@ export class OAuthService {
       query,
       redirect
     }
+
     const payload = grant?.response || result?.session?.response || result?.state?.response || params.query
     const authentication = {
       strategy: name,
       ...payload
     }
 
+    if (payload.error) {
+      throw new OAuthError(payload.error_description || payload.error, payload)
+    }
+
     try {
       debug(`Calling ${authService}.create authentication with strategy ${name}`)