fix(query) add minimum_should_match = 1 to the "should" query #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem appeared when the `$or` filter was used alongside other filters (outside the `$or` group). Expected behaviour is that at least one of the filters in the `$or` group AND all the filters outside the `$or` group should be met. Elasticsearch by default returns correct results when there is only the `$or` (Es: should) filter. However, when there are other filters present, should seems to be ignored. Setting `minimum_should_match = 1` fixes the problem.
|
Released as v0.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The problem appeared when the
$orfilter was usedalongside other filters (outside the
$orgroup).Expected behaviour is that at least one of the filters
in the
$orgroup AND all the filtersoutside the
$orgroup should be met.Elasticsearch by default returns correct results when there is only
the
$or(Es: should) filter. However, when there are other filterspresent, should seems to be ignored.
Setting
minimum_should_match = 1fixes the problem.Other Information
I have added relevant test just to make sure this issues does not resurface in the future.