Add full-text and term level queries specific to Elasticsearch #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2017
Closed
|
Released as v0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests deals with #1 by enabling three full-text queries in the adapter:
As a bonus, there is also one term level query thrown into the mix:
And the simplest query there is:
The implementation is fairly simple, as the existing parser for query parameters is easily extendable. I have added relevant tests.
I did not want to introduce long query names (e.g. $match_phrase_prefix) and at the same time did not want ambiguous acronyms, so went for a compromise.
Other Information
This PR also deals with testing the adapter on several versions of Elasticsearch. So far we had several branches, each for a different Es version. It was ok as a starting point, but quickly became cumbersome, so I have gathered all variations in one Travis config and slightly changed the test entry point as well as the test app in order to choose Es setup for 2.4 or 5.x based on env variable (ES_VERSION).
Docs PR already filed.