Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Elasticsearch 6.0+ #49

Merged
merged 5 commits into from
May 16, 2018

Conversation

jciolek
Copy link
Collaborator

@jciolek jciolek commented May 16, 2018

Summary

Due to the breaking change in Elasticsearch 6.0, namely removal of mapping types and consequently changes in parent-child relationship, parent-child handling had to be updated.

Even though in Elasticsearch 6.0 it is a breaking change, I managed to keep the service API consistent, and continue support across the whole range of versions (2.4 - 6.3). The upgrade should not cause any problems for existing installations.

A few important notes:

  • New service options have been introduced:
    • esVersion
    • join
    • routing
  • Test db schema have been changed slightly in order to accommodate the changes in Elasticsearch described above. Consequently, the tests have been changed as well, in order to avoid unnecessary repetition.
  • The core functions are now gathered in a core container, which became a property of the service. The container is created for each service instance and selects appropriate versions of the core functions, based on the esVersion options. This ensures that dependencies between core functions are always valid.
  • I have also replaced dated istanbul with nyc.

@jciolek jciolek requested a review from daffl May 16, 2018 23:13
@daffl daffl merged commit ef2206f into feathersjs-ecosystem:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants