Updates #44
Merged
Updates #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, upgrade elasticsearch client to 14.1.0 and api version to the actual elasticsearch version used in the test app.
This is to prepare for serving slightly different schema for Es 6.0. There were some breaking changes, e.g. around parent-child relationship. Moving schema management to a separate file should allow the tests to stay focused and not care much about particularites of the db config.
|
When will this be merged? I'm keen on ES6 support (only one type per index, routing-property mandatory for parent/child). I can try to contribute, but first this thingy here should be integrated? |
|
Hey @salamynder, I'm actively working on Elasticsearch 6.x support. There is another PR #45 for general maintenance and after that there will be one with Elasticsearch 6.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
General maintenance, including preparation for Elasticsearch 6.x support:
$nestedand$sqs.test-db.jsfile will be dealing with schema differences between Elasticsearch 6.x and 5.x.