Skip to content
This repository was archived by the owner on Sep 11, 2018. It is now read-only.

Conversation

@happydenn
Copy link
Contributor

Summary

When integrating with a custom OAuth2 provider using passport-oauth2 strategy, state option is set to true to support the authorization code grant flow and state verification.

However, since this option is also passed to the authenticate method of the OAuth2Strategy instance, which causes it to skip generating a random value and use the passed-in value directly instead, resulting in the current outcome.

Other Information

Lines from passport-oauth2 that used state option directly in authorizationURL: https://github.com/jaredhanson/passport-oauth2/blob/master/lib/strategy.js#L226-L234

@daffl
Copy link
Member

daffl commented Aug 28, 2018

Thank you!

@daffl daffl merged commit 8ae3bf3 into feathersjs-ecosystem:master Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants