This repository was archived by the owner on Sep 11, 2018. It is now read-only.
Fix state=true in authorizationURL integrating passport-oauth2 #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When integrating with a custom OAuth2 provider using
passport-oauth2strategy,stateoption is set totrueto support the authorization code grant flow and state verification.However, since this option is also passed to the
authenticatemethod of theOAuth2Strategyinstance, which causes it to skip generating a random value and use the passed-in value directly instead, resulting in the current outcome.Other Information
Lines from passport-oauth2 that used state option directly in authorizationURL: https://github.com/jaredhanson/passport-oauth2/blob/master/lib/strategy.js#L226-L234