perf: Remove redundant entity key serialization in online_read#6006
Open
abhijeet-dhumal wants to merge 1 commit intofeast-dev:masterfrom
Open
perf: Remove redundant entity key serialization in online_read#6006abhijeet-dhumal wants to merge 1 commit intofeast-dev:masterfrom
abhijeet-dhumal wants to merge 1 commit intofeast-dev:masterfrom
Conversation
abhijeet-dhumal
force-pushed
the
perf/remove-redundant-entity-key-serialization
branch
from
e09e3ff to
49add6b
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ntkathole
force-pushed
the
perf/remove-redundant-entity-key-serialization
branch
from
49add6b to
20ec3f0
Compare
abhijeet-dhumal
force-pushed
the
perf/remove-redundant-entity-key-serialization
branch
from
9375456 to
aa04d40
Compare
abhijeet-dhumal
force-pushed
the
perf/remove-redundant-entity-key-serialization
branch
from
97db073 to
20b8e46
Compare
ntkathole
reviewed
Feb 23, 2026
| + ")" | ||
| ) | ||
| for combo in itertools.product(entity_keys, requested_features) | ||
| for i, entity_key in enumerate(entity_keys) |
Member
There was a problem hiding this comment.
I think it's better if we do enumerate(serialized_entity_keys)
Author
There was a problem hiding this comment.
Thanks Nikhil for reviewing, Yeah that makes sense..
Even further instead of using enumerate I have used direct iteration now, as no index needed here ✅
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
abhijeet-dhumal
force-pushed
the
perf/remove-redundant-entity-key-serialization
branch
from
20b8e46 to
4686562
Compare
Author
|
@franciscojavierarceo May I request your review here ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes redundant entity key serialization in
online_read()for SQLite and Snowflake online stores.Before: Entity keys were serialized twice - once for the query and again when iterating results
After: Pre-computed
serialized_entity_keyslist is reusedChanges
serialized_entity_keysinstead of re-callingserialize_entity_key()in result loopBenchmark Results (SQLite)
Test Plan
Fixes #6005