perf: Optimize _convert_rows_to_protobuf timestamp conversion#6003
Open
abhijeet-dhumal wants to merge 1 commit intofeast-dev:masterfrom
Open
perf: Optimize _convert_rows_to_protobuf timestamp conversion#6003abhijeet-dhumal wants to merge 1 commit intofeast-dev:masterfrom
abhijeet-dhumal wants to merge 1 commit intofeast-dev:masterfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
abhijeet-dhumal
force-pushed
the
perf/optimize-protobuf-timestamp-conversion
branch
2 times, most recently
from
3ea1ee5 to
f9df866
Compare
ntkathole
changed the title
ntkathole
force-pushed
the
perf/optimize-protobuf-timestamp-conversion
branch
from
f9df866 to
c0a0475
Compare
abhijeet-dhumal
force-pushed
the
perf/optimize-protobuf-timestamp-conversion
branch
from
b6a4904 to
ea6160d
Compare
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
abhijeet-dhumal
force-pushed
the
perf/optimize-protobuf-timestamp-conversion
branch
from
391c17c to
f4a0ed7
Compare
Author
|
@ntkathole @franciscojavierarceo May I request your review here ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6004
Benchmark Results
The phase dropped from 27ms to ~5ms for the stress test.
Changes
Test Plan