Skip to content

fix: Resolve mypy [valid-type] error for TorchTensor TypeAlias #5984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −1
Draft

fix: Resolve mypy [valid-type] error for TorchTensor TypeAlias #5984

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59c3ef7
Initial plan
Copilot Feb 18, 2026
a5f8edf
Fix TorchTensor TypeAlias mypy error by moving TypeAlias import insid…
Copilot Feb 18, 2026
c611f91
Merge branch 'master' into copilot/fix-torch-tensor-type-error
franciscojavierarceo Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sdk/python/feast/online_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from typing import TYPE_CHECKING, Any, Dict, List, TypeAlias, Union
from typing import TYPE_CHECKING, Any, Dict, List, Union

import pandas as pd
import pyarrow as pa
Expand All @@ -23,10 +23,14 @@
from feast.type_map import feast_value_type_to_python_type

if TYPE_CHECKING:
from typing import TypeAlias

import torch

TorchTensor: TypeAlias = torch.Tensor
else:
from typing import TypeAlias

TorchTensor: TypeAlias = Any

TIMESTAMP_POSTFIX: str = "__ts"
Expand Down
Loading