Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added docling and pytorch as add on #5089

Merged
merged 2 commits into from
Feb 27, 2025
+612 −20
Merged

feat: Added docling and pytorch as add on #5089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7778335
feat: Added docling and pytorch as add on
ntkathole Feb 25, 2025
adee3e0
Use multicloud/Dockerfile instead of Dockerfile.dev for operator e2e
ntkathole Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,12 @@ build-feast-operator-docker:

# Dev images

build-feature-server-dev-minimal:
docker buildx build \
-t feastdev/feature-server:dev \
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile \
--load sdk/python/feast/infra/feature_servers/multicloud

Comment on lines +530 to +535
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a release build... its not a dev image build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to remove this

build-feature-server-dev:
docker buildx build \
-t feastdev/feature-server:dev \
Expand Down
2 changes: 1 addition & 1 deletion docs/getting-started/architecture/push-vs-pull-model.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ Implicit in the Push model are decisions about _how_ and _when_ to push feature

From a developer's perspective, there are three ways to push feature values to the online store with different tradeoffs.

They are discussed further in the [Write Patterns](getting-started/architecture/write-patterns.md) section.
They are discussed further in the [Write Patterns](write-patterns.md) section.
2 changes: 1 addition & 1 deletion docs/getting-started/architecture/write-patterns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Writing Data to Feast

Feast uses a [Push Model](getting-started/architecture/push-vs-pull-model.md) to push features to the online store.
Feast uses a [Push Model](push-vs-pull-model.md) to push features to the online store.

This has two important consequences: (1) communication patterns between the Data Producer (i.e., the client) and Feast (i.e,. the server) and (2) feature computation and
_feature value_ write patterns to Feast's online store.
Expand Down
2 changes: 1 addition & 1 deletion infra/feast-operator/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ docker-build: ## Build docker image with the manager.
## Build feast docker image.
.PHONY: feast-ci-dev-docker-img
feast-ci-dev-docker-img:
cd ./../.. && make build-feature-server-dev
cd ./../.. && make build-feature-server-dev-minimal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscojavierarceo Since we do not have larger runner to run kind + feast with all dependencies, either we need self-hosted runners or we need to use image with minimal dependencies installed in CI.
Currently moving from multicloud/Dockerfile.dev to multicloud/Dockerfile works in CI to run operator e2e test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is that we miss potential breaks by using this minimal image. That's the risk here, right?

Cc @lokeshrangineni @tchughesiv @redhatHameed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be using this image just for operator e2e test, feast functionality will be tested via integration and unit tests with all dependencies installed.
@tchughesiv or someone more familiar with operator work can confirm if it's a big risk in operator testing or better way to handle this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change needs to be reverted

Copy link
Contributor

@tchughesiv tchughesiv Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntkathole @franciscojavierarceo this must remain make build-feature-server-dev



.PHONY: docker-push
Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ azure = [
cassandra = ["cassandra-driver>=3.24.0,<4"]
couchbase = ["couchbase==4.3.2"]
delta = ["deltalake"]
docling = ["docling>=2.23.0"]
duckdb = ["ibis-framework[duckdb]>=9.0.0,<10"]
elasticsearch = ["elasticsearch>=8.13.0"]
faiss = ["faiss-cpu>=1.7.0,<2"]
Expand Down Expand Up @@ -94,6 +95,7 @@ opentelemetry = ["prometheus_client", "psutil"]
spark = ["pyspark>=3.0.0,<4"]
trino = ["trino>=0.305.0,<0.400.0", "regex"]
postgres = ["psycopg[binary,pool]>=3.0.0,<4"]
pytorch = ["torch>=2.2.2", "torchvision>=0.17.2"]
qdrant = ["qdrant-client>=1.12.0"]
redis = [
"redis>=4.2.2,<5",
Expand Down Expand Up @@ -148,8 +150,9 @@ ci = [
"types-setuptools",
"types-tabulate",
"virtualenv<20.24.2",
"feast[aws, azure, cassandra, couchbase, delta, duckdb, elasticsearch, faiss, gcp, ge, go, grpcio, hazelcast, hbase, ibis, ikv, k8s, milvus, mssql, mysql, opentelemetry, spark, trino, postgres, qdrant, redis, singlestore, snowflake, sqlite_vec]"
"feast[aws, azure, cassandra, couchbase, delta, docling, duckdb, elasticsearch, faiss, gcp, ge, go, grpcio, hazelcast, hbase, ibis, ikv, k8s, milvus, mssql, mysql, opentelemetry, spark, trino, postgres, pytorch, qdrant, redis, singlestore, snowflake, sqlite_vec]"
]
nlp = ["feast[docling, milvus, pytorch]"]
dev = ["feast[ci]"]
docs = ["feast[ci]"]

Expand Down
Loading
Loading