Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixing Milvus integration test configuration #4883

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
updated
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
franciscojavierarceo committed Jan 2, 2025
commit 6f521e9bd49fe23d2b95307cacabeb10861936ca
1 change: 0 additions & 1 deletion sdk/python/feast/templates/milvus/bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,3 @@ def bootstrap():

if __name__ == "__main__":
bootstrap()

Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
from typing import Any, Dict

# from testcontainers.milvus import MilvusContainer
from testcontainers.core.container import DockerContainer
from testcontainers.core.waiting_utils import wait_for_logs
from testcontainers.milvus import MilvusContainer

from tests.integration.feature_repos.universal.online_store_creator import (
OnlineStoreCreator,
Expand All @@ -12,18 +13,22 @@ class MilvusOnlineStoreCreator(OnlineStoreCreator):
def __init__(self, project_name: str, **kwargs):
super().__init__(project_name)
self.fixed_port = 19530
self.container = MilvusContainer("milvusdb/milvus:v2.4.4").with_exposed_ports(
self.container = DockerContainer("milvusdb/milvus:latest").with_exposed_ports(
self.fixed_port
)
# self.container = MilvusContainer("milvusdb/milvus:v2.4.4").with_exposed_ports(
# self.fixed_port
# )

def create_online_store(self) -> Dict[str, Any]:
self.container.start()
# Wait for Milvus server to be ready
host = "localhost"
port = self.container.get_exposed_port(self.fixed_port)
log_string_to_wait_for = "Ready to accept connections"
# log_string_to_wait_for = "Ready to accept connections"
log_string_to_wait_for = ""
wait_for_logs(
container=self.container, predicate=log_string_to_wait_for, timeout=10
container=self.container, predicate=log_string_to_wait_for, timeout=30
)
return {
"type": "milvus",
Expand Down
Loading