feat: Postgres offline_write_batch #4452
Open
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atry
force-pushed
the
postgresql_offline_write_batch
branch
2 times, most recently
from
4a93002 to
d8e0722
Compare
| @@ -229,6 +237,59 @@ def pull_all_from_table_or_query( | |||
| on_demand_feature_views=None, | |||
| ) | |||
|
|
|||
| if "adbc_driver_postgresql" in sys.modules: | |||
There was a problem hiding this comment.
could we instead add this to the config optionally?
There was a problem hiding this comment.
@franciscojavierarceo What config?
Co-authored-by: Nikita Demashov <n.demashov@yadro.com> Signed-off-by: Yang, Bo <bo.yang@protonbase.io>
Atry
force-pushed
the
postgresql_offline_write_batch
branch
from
d8e0722 to
2145d1d
Compare
|
@Atry @franciscojavierarceo hello. Are you planning to resume any activity on this MR? I reckon it's really necessary thing, because the current realization of PostgreSQLOfflineStore looks incomplete. I can bring some help if necessary. |
|
@Atry can you rebase this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement offline_write_batch for postgresql offline store.
Which issue(s) this PR fixes:
Fixes #3759
Misc
This PR is based on #3767, with some extra changes to create the table if it does not exist