-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adjusting the file version validation for minor releases #4221
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite validation, this is still not going to work, as line 48 looks for the passed current_version
to replace in files. I think much easier solution is to simply revert version bumps.
The version bumps are automatically generated through this code. Are you suggesting we do that for every patch release @tokoko? Also, I'll fix line 48. |
@franciscojavierarceo No, version bumps to 0.37.1 was automatic, but not on master, it was done on |
Got it! I missed this, my bad. Lack of sleep 🥲 . |
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
* adjusting the validation for branch updates Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updated to get parsed version Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> --------- Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
What this PR does / why we need it:
This is changing the validation to ignore patch version changes. So the CI should trigger correctly for increments from
0.37.1
->0.38.0
.Previously this failed as
0.37.1
wasn't recognized as a tag.Which issue(s) this PR fixes:
Fixes