Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjusting the file version validation for minor releases #4221

Merged
merged 2 commits into from
May 24, 2024

Conversation

franciscojavierarceo
Copy link
Member

@franciscojavierarceo franciscojavierarceo commented May 23, 2024

What this PR does / why we need it:

This is changing the validation to ignore patch version changes. So the CI should trigger correctly for increments from 0.37.1 -> 0.38.0.

python infra/scripts/release/bump_file_versions.py 0.37.0 0.38.0
Updated 16 files with new version 0.38.0

Previously this failed as 0.37.1 wasn't recognized as a tag.

Which issue(s) this PR fixes:

Fixes

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@franciscojavierarceo franciscojavierarceo changed the title chore: adjusting the file version validation for minor releases chore: Adjusting the file version validation for minor releases May 23, 2024
Copy link
Collaborator

@sudohainguyen sudohainguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😄

Copy link
Collaborator

@tokoko tokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite validation, this is still not going to work, as line 48 looks for the passed current_version to replace in files. I think much easier solution is to simply revert version bumps.

@franciscojavierarceo
Copy link
Member Author

franciscojavierarceo commented May 24, 2024

Despite validation, this is still not going to work, as line 48 looks for the passed current_version to replace in files. I think much easier solution is to simply revert version bumps.

The version bumps are automatically generated through this code. Are you suggesting we do that for every patch release @tokoko?

Also, I'll fix line 48.

@tokoko
Copy link
Collaborator

tokoko commented May 24, 2024

@franciscojavierarceo No, version bumps to 0.37.1 was automatic, but not on master, it was done on v-0.37-branch. We manually introduced those version bumps to master with a later PR (#4127) which was a mistake. I don't mind if we scrap validation from the scripts either, just pointing out that it's unnecessary if we simply revert some of the changes from that PR (version bumps specifically).

@franciscojavierarceo
Copy link
Member Author

We manually introduced those version bumps to master with a later PR (#4127) which was a mistake.

Got it! I missed this, my bad. Lack of sleep 🥲 .

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@franciscojavierarceo
Copy link
Member Author

@tokoko #4227

@franciscojavierarceo franciscojavierarceo merged commit fffc366 into master May 24, 2024
18 checks passed
franciscojavierarceo added a commit that referenced this pull request May 27, 2024
* adjusting the validation for branch updates

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

* updated to get parsed version

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

---------

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@tokoko tokoko deleted the version-validation-patch branch July 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants