-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update readme spark.md #3992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com>
ElliotNguyen68
changed the title
chore: update readme spark.md
chore: Update readme spark.md
Mar 7, 2024
HaoXuAI
approved these changes
Mar 7, 2024
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Mar 7, 2024
update readme spark.md Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> Co-authored-by: tanlocnguyen <tanlocnguyen296@gmail.com>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Mar 7, 2024
update readme spark.md Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> Co-authored-by: tanlocnguyen <tanlocnguyen296@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
HaoXuAI
pushed a commit
that referenced
this pull request
Mar 9, 2024
update readme spark.md Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> Co-authored-by: tanlocnguyen <tanlocnguyen296@gmail.com>
HaoXuAI
added a commit
that referenced
this pull request
Mar 9, 2024
* fix: remove not use input parameter in spark source (#3980) remove unused parameter when init sparksource Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> Co-authored-by: tanlocnguyen <tanlocnguyen296@gmail.com> * fix: Added registryPath parameter documentation in WebUI reference (#3983) * fix: Added registryPath parameter documentation Added a note in Webui reference in regard to supported registryPath values Related to #3974 Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * fix: Added registryPath parameter documentation Added a note in Webui reference in regard to supported registryPath values Related to #3974 Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * fix: Get container host addresses from testcontainers (#3946) * fix: get container host addresses from testcontainers Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * resolve trino container host with testcontainers Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * fix: Swap security label check on the PR title validation job to explicit permissions instead (#3987) revert security label check for PR title validation & add explicit read-only permission instead Signed-off-by: Jeremy Ary <jary@redhat.com> * feat: Add Entity df in format of a Spark Dataframe instead of just pd.DataFrame or string for SparkOfflineStore (#3988) * remove unused parameter when init sparksource Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> * feat: add entity df to SparkOfflineStore when get_historical_features Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> * fix: lint error Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> --------- Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> Co-authored-by: tanlocnguyen <tanlocnguyen296@gmail.com> * feat: Dropping unit tests for Python 3.8 (#3989) feat: dropping unit tests for Python 3.8 Update unit_tests.yml to no longer run for Python 3.8 Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> * fix: Move gRPC dependencies to an extra (#3900) * chore: Bump ip from 1.1.5 to 1.1.9 in /ui (#3959) * chore: Update readme spark.md (#3992) update readme spark.md Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> Co-authored-by: tanlocnguyen <tanlocnguyen296@gmail.com> * feat: Dropping Python 3.8 from local integration tests and integration tests (#3994) * fix: Handle ComplexFeastType to None comparison (#3876) Signed-off-by: Aliaksandr Sasnouskikh <jahstreetlove@gmail.com> * feat: Add python client for remote registry server (#3941) * add remote registry Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * format and lint remote registry code Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * add read-only registry exception Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> Signed-off-by: tokoko <togurg14@freeuni.edu.ge> Signed-off-by: Jeremy Ary <jary@redhat.com> Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> Signed-off-by: Aliaksandr Sasnouskikh <jahstreetlove@gmail.com> Co-authored-by: locnt241 <73770977+ElliotNguyen68@users.noreply.github.com> Co-authored-by: tanlocnguyen <tanlocnguyen296@gmail.com> Co-authored-by: Theodor Mihalache <84387487+tmihalac@users.noreply.github.com> Co-authored-by: Tornike Gurgenidze <togurg14@freeuni.edu.ge> Co-authored-by: Jeremy Ary <jary@redhat.com> Co-authored-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com> Co-authored-by: cburroughs <chris.burroughs@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Sasnouskikh <jahstreetlove@gmail.com>
tqtensor
pushed a commit
to tqtensor/feast
that referenced
this pull request
Mar 11, 2024
update readme spark.md Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com> Co-authored-by: tanlocnguyen <tanlocnguyen296@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: After have #3988, we may want to change readme for spark source for a more comprehensive guidance for user
Which issue(s) this PR fixes:
Fixes #