changed proxy fix to use BrowserRouter basename#3541
Closed
shumway743 wants to merge 1 commit intofeast-dev:masterfrom
Closed
changed proxy fix to use BrowserRouter basename#3541shumway743 wants to merge 1 commit intofeast-dev:masterfrom
shumway743 wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shumway743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR simplifies the way the feast UI can run on a sub path, which is often needed when running behind a proxy. Instead of manually attaching an environment variable in front of each link/path, links are updated using the basename prop of BrowserRouter and exposes it as a prop on the FeastUI component. The primary benefit is maintainability (no need for links to be updated manually).
With this, a subpath can be specified by passing the basename prop, and by updating the projectListPromise on the FeastUI component in an index.js/index.tsx file.
An example running under the subpath "/feast" would look something like this:
<FeastUI basename="/feast" reactQueryClient={queryClient} feastUIConfigs={{ tabsRegistry: tabsRegistry, projectListPromise: fetch("/feast/projects-list.json", { headers: { "Content-Type": "application/json", }, }).then((res) => { return res.json(); }) }} />Which issue(s) this PR fixes:
Fixes #