Skip to content

Comments

fix: Support param timeout when persisting#3504

Closed
sudohainguyen wants to merge 6 commits intofeast-dev:masterfrom
sudohainguyen:fix/persist_timeout
Closed

fix: Support param timeout when persisting#3504
sudohainguyen wants to merge 6 commits intofeast-dev:masterfrom
sudohainguyen:fix/persist_timeout

Conversation

@sudohainguyen
Copy link
Collaborator

What this PR does / why we need it: to support declaring timeout when persisting historical retrieval job

Which issue(s) this PR fixes:

Fixes #

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sudohainguyen
To complete the pull request process, please assign felixwang9817 after the PR has been reviewed.
You can assign the PR to them by writing /assign @felixwang9817 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sudohainguyen sudohainguyen changed the title WIP: fix: Support param timeout when persisting fix: Support param timeout when persisting Feb 21, 2023
@gbmarc1
Copy link
Contributor

gbmarc1 commented Feb 22, 2023

Hello @sudohainguyen !
I am working on a similar PR but for to_df and to_arrow methods.

  • I think it would be good to add unit-tests to those methods.
  • What about Optional[int] with default None if you don't want a timeout.

@sudohainguyen
Copy link
Collaborator Author

Hello @sudohainguyen ! I am working on a similar PR but for to_df and to_arrow methods.

  • I think it would be good to add unit-tests to those methods.

sure let me see

@sudohainguyen
Copy link
Collaborator Author

sudohainguyen commented Feb 23, 2023

  • What about Optional[int] with default None if you don't want a timeout.

@gbmarc1 there should always be a timeout I believe

Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
@sudohainguyen
Copy link
Collaborator Author

just rebased

Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
@sudohainguyen
Copy link
Collaborator Author

@achals do you think we still need this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants