fix: Support param timeout when persisting#3504
fix: Support param timeout when persisting#3504sudohainguyen wants to merge 6 commits intofeast-dev:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sudohainguyen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
98aaa1b to
948ac8e
Compare
948ac8e to
faace82
Compare
|
Hello @sudohainguyen !
|
sure let me see |
@gbmarc1 there should always be a timeout I believe |
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
8319cc7 to
65a94dd
Compare
|
just rebased |
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
e46fdd2 to
56e790e
Compare
|
@achals do you think we still need this PR? |
What this PR does / why we need it: to support declaring timeout when persisting historical retrieval job
Which issue(s) this PR fixes:
Fixes #