fix: Protobuf lower bound to 3.20 to alert that Feast is incompatible with tensorflow

[gbmarc1]

What this PR does / why we need it:
protobuf in python sdk should be lower bound to 3.20 because they introduced the builder in 3.20.

feast/protos/feast/types/Value_pb2.py:5
      1 # -*- coding: utf-8 -*-
      2 # Generated by the protocol buffer compiler.  DO NOT EDIT!
      3 # source: feast/types/Value.proto
      4 """Generated protocol buffer code."""
----> 5 from google.protobuf.internal import builder as _builder
      6 from google.protobuf import descriptor as _descriptor
      7 from google.protobuf import descriptor_pool as _descriptor_pool

ImportError: cannot import name 'builder' from 'google.protobuf.internal' /lib/python3.9/site-packages/google/protobuf/internal/__init__.py)

Which issue(s) this PR fixes:

Fixes #3287

[gbmarc1]

/assign @sfc-gh-madkins

[achals]

I think you'll have to regenerate the requirements.txt files. There's a command in the makefile that you can use to do that!

[gbmarc1]

@achals Done!

[adchia]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, gbmarc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adchia]

@cburroughs mentioned that Tensorflow requires a Protobuf version < 3.20

[cburroughs]

Hey sorry I missed the github notification for this earlier!

At least for me the original impetuous for #3287 was that tensorflow requires protobuf < 3.20. If you download the latest version on PyPi today (tensorflow==2.11.0)

    # TODO(b/182876485): Protobuf 3.20 results in linker errors on Windows
    # Protobuf 4.0 is binary incompatible with what C++ TF uses.
    # We need ~1 quarter to update properly.
    # See also: https://github.com/tensorflow/tensorflow/issues/53234
    # See also: https://github.com/protocolbuffers/protobuf/issues/9954
    # See also: https://github.com/tensorflow/tensorflow/issues/56077
    # This is a temporary patch for now, to patch previous TF releases.
    'protobuf >= 3.9.2, < 3.20',

Tensorflow is a pretty popular machine learning library and I'd like to be able to use it with Feast.

I'm not a protobuf expert but my understanding from protocolbuffers/protobuf#9778 is that if you use version X to generate the code, then it is only guaranteed to work with version >=X. So if Feast as a requirement on >=3.20 the minimum version isn't' "3.20" but "whatever version >=3.20 that happened to be resolved when the release process runs". That means a similar problem could occur in the future any time Feast cuts a release. I think a separate step (in the makefile?) will need to to pin to an explicit version.

[gbmarc1]

@cburroughs,
Actually, current Feast version is not compatible with protobuf<3.20. Installing a virtual environment with feast and tensorflow==2.11 would not raise an incompatibility error. But when importing Feast, an error would raise because there would be a missing method in protobuf.

      1 # -*- coding: utf-8 -*-
      2 # Generated by the protocol buffer compiler.  DO NOT EDIT!
      3 # source: feast/types/Value.proto
      4 """Generated protocol buffer code."""
----> 5 from google.protobuf.internal import builder as _builder
      6 from google.protobuf import descriptor as _descriptor
      7 from google.protobuf import descriptor_pool as _descriptor_pool

ImportError: cannot import name 'builder' from 'google.protobuf.internal' (/opt/miniconda/envs/env/lib/python3.9/site-packages/google/protobuf/internal/__init__.py)

Note that they updated the protobuf version in tensorflow==2.12. It is already merged on master and available on this release candiate.

[cburroughs]

Actually, current Feast version is not compatible with protobuf<3.20.

Correct! That is the regression between 0.25.0 and 0.25.1 reported in #3287

[adchia]

/lgtm

[adchia]

/lgtm