chore: Move google-api dependencies to GCP extras#3463
Merged
feast-ci-bot merged 2 commits intofeast-dev:masterfrom Feb 13, 2023
Merged
chore: Move google-api dependencies to GCP extras#3463feast-ci-bot merged 2 commits intofeast-dev:masterfrom
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
Conversation
cburroughs
changed the title
felixwang9817
changed the title
These dependencies were added before any extras existed in setup.py. Feast users would generally expect that using AWS or Azure does not require Google Cloud apis. Fixex feast-dev#3458 Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia, cburroughs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These dependencies were added before any extras existed in setup.py. Feast users would generally expect that using AWS or Azure does not require Google Cloud apis.
Fixex #3458
Signed-off-by: Chris Burroughs chris.burroughs@gmail.com