-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Build docker images in build_wheels.yml
#3244
chore: Build docker images in build_wheels.yml
#3244
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
3213a39
to
9537db2
Compare
Sorry, does this new step just build the images without pushing? |
yup that's all it does for context, the Docker images didn't build properly when I did the 0.25.0 release, which really messed up the process - this will verify beforehand that images build properly, so that any issues can be fixed before the release process runs |
any particular reason why GCP credentials are needed? Don't see anything in the Dockerfile that particularly seems to call out to Google |
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov ReportBase: 67.50% // Head: 58.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3244 +/- ##
==========================================
- Coverage 67.50% 58.16% -9.34%
==========================================
Files 179 213 +34
Lines 16371 17825 +1454
==========================================
- Hits 11051 10368 -683
- Misses 5320 7457 +2137
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Build docker images Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Update docs Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Also build Java docker image Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Clean up Signed-off-by: Felix Wang <wangfelix98@gmail.com> Signed-off-by: Felix Wang <wangfelix98@gmail.com>
* Build docker images Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Update docs Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Also build Java docker image Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Clean up Signed-off-by: Felix Wang <wangfelix98@gmail.com> Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #