Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Build docker images in build_wheels.yml #3244

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@achals
Copy link
Member

achals commented Sep 23, 2022

Sorry, does this new step just build the images without pushing?

@felixwang9817
Copy link
Collaborator Author

felixwang9817 commented Sep 23, 2022

Sorry, does this new step just build the images without pushing?

yup that's all it does

for context, the Docker images didn't build properly when I did the 0.25.0 release, which really messed up the process - this will verify beforehand that images build properly, so that any issues can be fixed before the release process runs

@adchia
Copy link
Collaborator

adchia commented Sep 26, 2022

any particular reason why GCP credentials are needed? Don't see anything in the Dockerfile that particularly seems to call out to Google

@adchia adchia self-assigned this Sep 26, 2022
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Base: 67.50% // Head: 58.16% // Decreases project coverage by -9.33% ⚠️

Coverage data is based on head (1ad94ba) compared to base (a2dc0d0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3244      +/-   ##
==========================================
- Coverage   67.50%   58.16%   -9.34%     
==========================================
  Files         179      213      +34     
  Lines       16371    17825    +1454     
==========================================
- Hits        11051    10368     -683     
- Misses       5320     7457    +2137     
Flag Coverage Δ
integrationtests ?
unittests 58.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...n/tests/integration/registration/test_inference.py 35.71% <0.00%> (-64.29%) ⬇️
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 0ad7fe3 into feast-dev:master Sep 26, 2022
vmallya-123 pushed a commit to vmallya-123/feast that referenced this pull request Sep 27, 2022
* Build docker images

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Update docs

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Also build Java docker image

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Clean up

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
adchia pushed a commit that referenced this pull request Sep 30, 2022
* Build docker images

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Update docs

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Also build Java docker image

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Clean up

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants