Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add CODEOWNERS file to automate more code reviews #3192

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 7, 2022

This is pending all the people mentioned in this are members of the Feast community and have write access

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@adchia adchia changed the title chore: Add CODEOWNERS file to automate more code reviews chore: Add CODEOWNERS file to automate more code reviews [WIP] Sep 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Base: 67.02% // Head: 75.69% // Increases project coverage by +8.67% 🎉

Coverage data is based on head (4fc632d) compared to base (782c759).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3192      +/-   ##
==========================================
+ Coverage   67.02%   75.69%   +8.67%     
==========================================
  Files         175      211      +36     
  Lines       15940    17923    +1983     
==========================================
+ Hits        10683    13567    +2884     
+ Misses       5257     4356     -901     
Flag Coverage Δ
integrationtests 66.85% <ø> (-0.17%) ⬇️
unittests 57.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/feast/infra/materialization/snowflake_engine.py 92.09% <0.00%> (-0.47%) ⬇️
.../contrib/athena_offline_store/tests/data_source.py 46.66% <0.00%> (ø)
...s/contrib/mssql_offline_store/tests/data_source.py 46.93% <0.00%> (ø)
...ffline_stores/contrib/spark_offline_store/spark.py 7.72% <0.00%> (ø)
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
sdk/python/feast/loaders/yaml.py 18.18% <0.00%> (ø)
...ffline_stores/contrib/athena_repo_configuration.py 100.00% <0.00%> (ø)
...ine_stores/contrib/cassandra_repo_configuration.py 100.00% <0.00%> (ø)
...tion/feature_repos/universal/online_store/hbase.py 50.00% <0.00%> (ø)
.../online_stores/contrib/hbase_repo_configuration.py 100.00% <0.00%> (ø)
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adchia adchia changed the title chore: Add CODEOWNERS file to automate more code reviews [WIP] chore: Add CODEOWNERS file to automate more code reviews Sep 8, 2022
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Collaborator

@kevjumba kevjumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit c19d640 into feast-dev:master Sep 9, 2022
@adchia adchia deleted the owners branch September 9, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants