Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove join_keys attribute #3159

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Base: 67.11% // Head: 76.13% // Increases project coverage by +9.01% 🎉

Coverage data is based on head (13c4ad5) compared to base (5ddb83b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
+ Coverage   67.11%   76.13%   +9.01%     
==========================================
  Files         175      211      +36     
  Lines       15907    17854    +1947     
==========================================
+ Hits        10676    13593    +2917     
+ Misses       5231     4261     -970     
Flag Coverage Δ
integrationtests 66.93% <100.00%> (-0.18%) ⬇️
unittests 58.28% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/entity.py 91.04% <ø> (+6.75%) ⬆️
sdk/python/feast/feature_view.py 96.66% <100.00%> (ø)
sdk/python/feast/inference.py 85.22% <100.00%> (+0.95%) ⬆️
...on/feast/infra/materialization/snowflake_engine.py 92.13% <0.00%> (-0.46%) ⬇️
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
sdk/python/feast/loaders/yaml.py 18.18% <0.00%> (ø)
...s/contrib/mssql_offline_store/tests/data_source.py 46.93% <0.00%> (ø)
...hon/feast/infra/utils/postgres/connection_utils.py 48.00% <0.00%> (ø)
.../feature_repos/universal/online_store/cassandra.py 42.85% <0.00%> (ø)
...thon/feast/infra/online_stores/contrib/postgres.py 32.69% <0.00%> (ø)
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@feast-ci-bot feast-ci-bot merged commit 857876b into feast-dev:master Aug 31, 2022
@felixwang9817 felixwang9817 deleted the remove_join_keys branch August 31, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants