Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Docs on structuring repos and scaling feast #3122

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

achals
Copy link
Member

@achals achals commented Aug 22, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall!

docs/how-to-guides/scaling-feast.md Show resolved Hide resolved
docs/how-to-guides/scaling-feast.md Outdated Show resolved Hide resolved
docs/how-to-guides/scaling-feast.md Outdated Show resolved Hide resolved
docs/how-to-guides/scaling-feast.md Outdated Show resolved Hide resolved
docs/how-to-guides/scaling-feast.md Outdated Show resolved Hide resolved
docs/how-to-guides/structuring-repos.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #3122 (a7340de) into master (1f5b1e0) will increase coverage by 8.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3122      +/-   ##
==========================================
+ Coverage   67.13%   76.03%   +8.90%     
==========================================
  Files         177      214      +37     
  Lines       15894    17899    +2005     
==========================================
+ Hits        10670    13610    +2940     
+ Misses       5224     4289     -935     
Flag Coverage Δ
integrationtests 66.96% <ø> (-0.17%) ⬇️
unittests 57.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/feast/infra/materialization/snowflake_engine.py 92.70% <0.00%> (-0.53%) ⬇️
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
...offline_stores/contrib/mssql_repo_configuration.py 100.00% <0.00%> (ø)
...ffline_stores/contrib/spark_offline_store/spark.py 33.15% <0.00%> (ø)
...ib/trino_offline_store/test_config/manual_tests.py 33.33% <0.00%> (ø)
...ores/contrib/mssql_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
...ontrib/postgres_offline_store/tests/data_source.py 51.02% <0.00%> (ø)
...thon/feast/infra/online_stores/contrib/postgres.py 32.69% <0.00%> (ø)
...ffline_stores/contrib/athena_repo_configuration.py 50.00% <0.00%> (ø)
...ffline_stores/contrib/trino_offline_store/trino.py 8.78% <0.00%> (ø)
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

achals added 2 commits August 22, 2022 11:40
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@felixwang9817
Copy link
Collaborator

/lgtm

@kevjumba kevjumba enabled auto-merge (squash) August 23, 2022 03:48
@kevjumba kevjumba disabled auto-merge August 23, 2022 03:48
@kevjumba kevjumba merged commit b4d0f6d into feast-dev:master Aug 23, 2022
@achals achals deleted the achal/docs branch August 26, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants