Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Check configs and data sources in all offline store methods #3107

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #3107 (00a9383) into master (83c5efb) will increase coverage by 9.20%.
The diff coverage is 43.58%.

@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
+ Coverage   67.08%   76.29%   +9.20%     
==========================================
  Files         173      210      +37     
  Lines       15132    17487    +2355     
==========================================
+ Hits        10152    13342    +3190     
+ Misses       4980     4145     -835     
Flag Coverage Δ
integrationtests 67.75% <94.44%> (+0.66%) ⬆️
unittests 57.79% <15.38%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...line_stores/contrib/athena_offline_store/athena.py 37.83% <0.00%> (ø)
..._stores/contrib/postgres_offline_store/postgres.py 34.14% <0.00%> (ø)
...ffline_stores/contrib/spark_offline_store/spark.py 33.15% <0.00%> (ø)
...ffline_stores/contrib/trino_offline_store/trino.py 8.78% <0.00%> (ø)
...python/feast/infra/offline_stores/offline_store.py 82.35% <ø> (-0.65%) ⬇️
sdk/python/feast/infra/offline_stores/bigquery.py 86.85% <83.33%> (+0.69%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 95.47% <100.00%> (+1.38%) ⬆️
sdk/python/feast/infra/offline_stores/redshift.py 96.60% <100.00%> (+1.43%) ⬆️
sdk/python/feast/infra/offline_stores/snowflake.py 93.36% <100.00%> (+9.03%) ⬆️
...hon/feast/infra/offline_stores/snowflake_source.py 89.85% <0.00%> (-2.46%) ⬇️
... and 120 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@kevjumba kevjumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 29f2895 into feast-dev:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants